fix: align column headers with text_justify_columns setting #8178
Open
maxkoretskyi wants to merge 2 commits intomarimo-team:mainfrom
Open
fix: align column headers with text_justify_columns setting #8178maxkoretskyi wants to merge 2 commits intomarimo-team:mainfrom
maxkoretskyi wants to merge 2 commits intomarimo-team:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Column headers now follow the same alignment as cell data when using
text_justify_columns.Closes #7967
Description of Changes
When
text_justify_columnsis set (e.g.,{"Age": "right"}), only cell data was aligned — column headers stayed left-aligned, creating a visual mismatch.The fix passes the
justifyvalue fromgenerateColumnsthrough toDataTableColumnHeader, which applies:flex-row-reversefor right-aligned columns (swaps the sort/filter icon to the left)text-right/text-centeron the header text spanBefore:
Headers left-aligned, data right-aligned.
After:
Headers match the cell data alignment.
Files changed:
column-header.tsx— acceptsjustifyprop, applies alignment classescolumns.tsx— passesjustifyto the header componentcolumns.test.tsx— adds test for header justificationChecklist